Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles better failure cases on Android Safe Browsing #19544

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Handles better failure cases on Android Safe Browsing #19544

merged 1 commit into from
Aug 2, 2023

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#31894

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Aug 2, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Aug 2, 2023
samartnik
samartnik approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AlexeyBarabash
AlexeyBarabash approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

deeppandya
deeppandya approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fmarier
fmarier approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think we might want to restrict Safe Browsing checks to just HTTP and HTTPS too (maybe in a separate PR).

...sing/android/java/src/org/chromium/components/safe_browsing/BraveSafeBrowsingApiHandler.java
@@ -142,12 +148,17 @@ public void startUriLookup(final long callbackId, String uri, int[] threatsOfInt
== SafetyNetStatusCodes.SAFE_BROWSING_API_NOT_INITIALIZED) {
initSafeBrowsing();
startUriLookup(callbackId, uri, threatsOfInterest);
} else {
mObserver.onUrlCheckDone(callbackId, SafeBrowsingResult.TIMEOUT, "{}",
DEFAULT_CHECK_DELTA);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is DEFAULT_CHECK_DELTA in seconds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// |check_delta| is the number of microseconds it took to look up the URL
// reputation from GmsCore.

@SergeyZhukovsky
Copy link
Member Author

Looks good to me, but I think we might want to restrict Safe Browsing checks to just HTTP and HTTPS too (maybe in a separate PR).

sounds good, I'll create a follow up

@SergeyZhukovsky SergeyZhukovsky merged commit c9c2268 into master Aug 2, 2023
@SergeyZhukovsky SergeyZhukovsky deleted the android_safe_browsing_facebook branch August 2, 2023 21:07
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Aug 2, 2023
brave-builds added a commit that referenced this pull request Aug 2, 2023
@brave-builds
Uplift of #19544 (squashed) to beta
703f969
@brave-builds brave-builds mentioned this pull request Aug 2, 2023
Merged
7 tasks
brave-builds added a commit that referenced this pull request Aug 2, 2023
@brave-builds
Uplift of #19544 (squashed) to release
232dda6
@brave-builds brave-builds mentioned this pull request Aug 2, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Aug 3, 2023

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.58.66 Chromium: 116.0.5845.51 (Official Build) canary (64-bit)
--- | ---
Revision | 760f994002820ae85421061cfac48e987a605c03
OS | Android 14; Build/UPB4.230623.007; 34; REL

Using the STR/Cases outlined via brave/brave-browser#31894 (comment), reproduced that FB was initially loading slowly as per the following:

screen-20230802-223929.mp4

Ensured that the page was loading quicker/shorter delay with 1.58.66 Chromium: 116.0.5845.51 as per the following:

screen-20230803-020734.mp4

kjozwiak pushed a commit that referenced this pull request Aug 3, 2023
@brave-builds
Handles better failure cases on Android Safe Browsing (uplift to 1.57…
fa9de79 
….x) (#19551)

Uplift of #19544 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Aug 3, 2023
@brave-builds
Handles better failure cases on Android Safe Browsing (uplift to 1.56…
5aa7e71 
….x) (#19552)

Uplift of #19544 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarier fmarier fmarier approved these changes

@deeppandya deeppandya deeppandya approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@samartnik samartnik samartnik approved these changes

Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.

[Android] Slow loading FB timeline
7 participants
@SergeyZhukovsky @kjozwiak @fmarier @deeppandya @AlexeyBarabash @samartnik @thypon